Attention is currently required from: Hung-Te Lin, Jarried Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu.
Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85858?usp=email )
Change subject: mb/google/rauru: Add alc5650 support ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85858/comment/f1bf0d72_196e333d?usp... : PS2, Line 9: depthcharge
the payload
Done
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85858/comment/c02c3d72_74bc3314?usp... : PS2, Line 21: i2s
I'm fine with doing that in this patch, as it's only straightforward refactoring.
Done
https://review.coreboot.org/c/coreboot/+/85858/comment/ba5e8789_ca545fc2?usp... : PS2, Line 33: {
Should we add `/* Switch to normal mode */` similar to the code above?
Done
https://review.coreboot.org/c/coreboot/+/85858/comment/6410829a_172e17e5?usp... : PS2, Line 34: write32p(AFE_SE_SECURE_CON1, 0x0);
A blank line below.
Done
https://review.coreboot.org/c/coreboot/+/85858/comment/cfd2ef4e_168fabfb?usp... : PS2, Line 52: printk(BIOS_INFO, "Audio configure ALC5645\n");
What about moving this log to `configure_alc5645` ? […]
Done