Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34089 )
Change subject: src/soc/intel/common/itss: Add support to get IRQ configuration for PCI devices ......................................................................
Patch Set 20:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34089/19/src/soc/intel/common/block... File src/soc/intel/common/block/itss/irq.c:
https://review.coreboot.org/c/coreboot/+/34089/19/src/soc/intel/common/block... PS19, Line 31: alteast
at least
Done,
Thanks!! for reviewing the CLs
https://review.coreboot.org/c/coreboot/+/34089/19/src/soc/intel/common/block... PS19, Line 69: printk(BIOS_ERR, "LPSS controller D: 0x%x F: 0x%x uses irq %d" : ", conflicts with gpio mapped to irq %d\n", : irq_entry->slot, irq_entry->func, int_lpss, : int_lpss);
Shouldn't we die() with this? It means there's a fatal configuration error, and I'm assuming that t […]
only if GPIO is configured as GPI and irq routing is set via IOAPIC, else we are fine. That would be a fatal configuration. Currently it would just up as a warning in logs? what do you think?
https://review.coreboot.org/c/coreboot/+/34089/19/src/soc/intel/common/block... PS19, Line 108: create_irq_entry(dev, &irq_entry); : irq_config[index] = irq_entry;
You could just do create_irq_entry(dev, &irq_config[index]) to avoid the extra copy
Ok, done.