Change in coreboot[master]: ibase/mb899: use common winbond/nuvoton HWM bank select function
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37949 )
Change subject: ibase/mb899: use common winbond/nuvoton HWM bank select function ......................................................................
ibase/mb899: use common winbond/nuvoton HWM bank select function
Change-Id: I7f159074c25a0fdfe2ee15024c1ed6c062ce75d5 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/ibase/mb899/Kconfig M src/mainboard/ibase/mb899/superio_hwm.c 2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/37949/1
diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig index d93121d..b3ffd2b 100644 --- a/src/mainboard/ibase/mb899/Kconfig +++ b/src/mainboard/ibase/mb899/Kconfig @@ -8,6 +8,7 @@ select CHECK_SLFRCS_ON_RESUME select SOUTHBRIDGE_INTEL_I82801GX select SUPERIO_WINBOND_W83627EHG + select SUPERIO_NUVOTON_COMMON_HWM # Nuvoton is a Winbond spin-off select HAVE_ACPI_TABLES select HAVE_PIRQ_TABLE select HAVE_MP_TABLE diff --git a/src/mainboard/ibase/mb899/superio_hwm.c b/src/mainboard/ibase/mb899/superio_hwm.c index aa88cc7..175c9a0 100644 --- a/src/mainboard/ibase/mb899/superio_hwm.c +++ b/src/mainboard/ibase/mb899/superio_hwm.c @@ -19,6 +19,7 @@ #include <device/device.h> #include <pc80/mc146818rtc.h> #include <superio/hwm5_conf.h> +#include <superio/nuvoton/common/hwm.h>
#include "superio_hwm.h"
@@ -82,16 +83,16 @@ // pnp_write_hwm5_index(HWM_BASE, 0x31, 0x20); // AVCC high limit // pnp_write_hwm5_index(HWM_BASE, 0x34, 0x06); // VIN2 low limit
- pnp_write_hwm5_index(HWM_BASE, 0x4e, 0); + nuvoton_hwm_select_bank(HWM_BASE, 0); pnp_write_hwm5_index(HWM_BASE, 0x59, 0x20); // Diode Selection pnp_write_hwm5_index(HWM_BASE, 0x5d, 0x0f); // All Sensors Diode, not Thermistor
- pnp_write_hwm5_index(HWM_BASE, 0x4e, 4); + nuvoton_hwm_select_bank(HWM_BASE, 4); pnp_write_hwm5_index(HWM_BASE, 0x54, 0xf1); // SYSTIN temperature offset pnp_write_hwm5_index(HWM_BASE, 0x55, 0x19); // CPUTIN temperature offset pnp_write_hwm5_index(HWM_BASE, 0x56, 0xfc); // AUXTIN temperature offset
- pnp_write_hwm5_index(HWM_BASE, 0x4e, 0x80); // Default + nuvoton_hwm_select_bank(HWM_BASE, 0x80); // Default
u8 fan_config = 0; // 00 FANOUT is Manual Mode
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37949 )
Change subject: ibase/mb899: use common winbond/nuvoton HWM bank select function ......................................................................
Patch Set 1: Code-Review+1
can't we "select SUPERIO_NUVOTON_COMMON_HWM" at 'src/superio/winbond/w83627ehg/Kconfig' ?
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37949 )
Change subject: ibase/mb899: use common winbond/nuvoton HWM bank select function ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
can't we "select SUPERIO_NUVOTON_COMMON_HWM" at 'src/superio/winbond/w83627ehg/Kconfig' ?
see my comment on 37946
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37949 )
Change subject: ibase/mb899: use common winbond/nuvoton HWM bank select function ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37949 )
Change subject: ibase/mb899: use common winbond/nuvoton HWM bank select function ......................................................................
ibase/mb899: use common winbond/nuvoton HWM bank select function
Change-Id: I7f159074c25a0fdfe2ee15024c1ed6c062ce75d5 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/37949 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/ibase/mb899/Kconfig M src/mainboard/ibase/mb899/superio_hwm.c 2 files changed, 5 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig index d93121d..b3ffd2b 100644 --- a/src/mainboard/ibase/mb899/Kconfig +++ b/src/mainboard/ibase/mb899/Kconfig @@ -8,6 +8,7 @@ select CHECK_SLFRCS_ON_RESUME select SOUTHBRIDGE_INTEL_I82801GX select SUPERIO_WINBOND_W83627EHG + select SUPERIO_NUVOTON_COMMON_HWM # Nuvoton is a Winbond spin-off select HAVE_ACPI_TABLES select HAVE_PIRQ_TABLE select HAVE_MP_TABLE diff --git a/src/mainboard/ibase/mb899/superio_hwm.c b/src/mainboard/ibase/mb899/superio_hwm.c index aa88cc7..175c9a0 100644 --- a/src/mainboard/ibase/mb899/superio_hwm.c +++ b/src/mainboard/ibase/mb899/superio_hwm.c @@ -19,6 +19,7 @@ #include <device/device.h> #include <pc80/mc146818rtc.h> #include <superio/hwm5_conf.h> +#include <superio/nuvoton/common/hwm.h>
#include "superio_hwm.h"
@@ -82,16 +83,16 @@ // pnp_write_hwm5_index(HWM_BASE, 0x31, 0x20); // AVCC high limit // pnp_write_hwm5_index(HWM_BASE, 0x34, 0x06); // VIN2 low limit
- pnp_write_hwm5_index(HWM_BASE, 0x4e, 0); + nuvoton_hwm_select_bank(HWM_BASE, 0); pnp_write_hwm5_index(HWM_BASE, 0x59, 0x20); // Diode Selection pnp_write_hwm5_index(HWM_BASE, 0x5d, 0x0f); // All Sensors Diode, not Thermistor
- pnp_write_hwm5_index(HWM_BASE, 0x4e, 4); + nuvoton_hwm_select_bank(HWM_BASE, 4); pnp_write_hwm5_index(HWM_BASE, 0x54, 0xf1); // SYSTIN temperature offset pnp_write_hwm5_index(HWM_BASE, 0x55, 0x19); // CPUTIN temperature offset pnp_write_hwm5_index(HWM_BASE, 0x56, 0xfc); // AUXTIN temperature offset
- pnp_write_hwm5_index(HWM_BASE, 0x4e, 0x80); // Default + nuvoton_hwm_select_bank(HWM_BASE, 0x80); // Default
u8 fan_config = 0; // 00 FANOUT is Manual Mode
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)