Attention is currently required from: Robert Zieba, Chris Wang, Karthik Ramasubramanian, Felix Held.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63132 )
Change subject: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63132/comment/f4cc114f_68a941ed
PS4, Line 16: SPD_SOURCES += $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memory/K4U6E3S4AB-MGCL.hex # ID = 9(0b1001) Parts = K4U6E3S4AB-MGCL
Is there no way to update the memory_parts. […]
+1. As is, this will get overwritten every time part_id_gen is run. We could modify apcb_v3_edit.py to inject the part number at this index. Alternatively, we could modify part_id_gen to support special spd binaries.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63132
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia54726ce8c1bae46dcd4fed3df509ef184914e94
Gerrit-Change-Number: 63132
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 28 Mar 2022 15:51:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Robert Zieba
robertzieba@google.com
Gerrit-MessageType: comment