Change in coreboot[master]: mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Felix Singer (Code Review)

6 Jan 2021 6 Jan '21

5:17 a.m.

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49138 )

Change subject: mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig ......................................................................

mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig

It doesn't make sense to configure that filename in Kconfig, since the filename can be changed either and is chosen by the user. So remove it.

Change-Id: I3eed05637da29096bc1d134505d7335db5db1439 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/49138/1

diff --git a/src/mainboard/clevo/cml-u/Kconfig b/src/mainboard/clevo/cml-u/Kconfig index f8bf1ba..5653fb4 100644 --- a/src/mainboard/clevo/cml-u/Kconfig +++ b/src/mainboard/clevo/cml-u/Kconfig @@ -66,10 +66,6 @@ int default 512

-config VGA_BIOS_FILE - string - default "pci8086,9b41.rom" - config VGA_BIOS_ID string default "8086,9b41"

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Angel Pons (Code Review)

6 Jan 6 Jan

2:15 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49138 )

Change subject: mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/49138/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/49138/2//COMMIT_MSG@10 PS2, Line 10: either and is chosen I'd drop this part

-- To view, visit https://review.coreboot.org/c/coreboot/+/49138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eed05637da29096bc1d134505d7335db5db1439 Gerrit-Change-Number: 49138 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Jan 2021 17:15:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

2:17 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49138

to look at the new patch set (#3).

Change subject: mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig ......................................................................

mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig

It doesn't make sense to configure that filename in Kconfig, since the filename can be changed by the user. So remove it.

Change-Id: I3eed05637da29096bc1d134505d7335db5db1439 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/49138/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/49138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eed05637da29096bc1d134505d7335db5db1439 Gerrit-Change-Number: 49138 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

2:17 p.m.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49138 )

Change subject: mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/49138/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/49138/2//COMMIT_MSG@10 PS2, Line 10: either and is chosen

...

I'd drop this part

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/49138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eed05637da29096bc1d134505d7335db5db1439 Gerrit-Change-Number: 49138 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Jan 2021 17:17:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

3:14 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49138 )

Change subject: mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/49138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eed05637da29096bc1d134505d7335db5db1439 Gerrit-Change-Number: 49138 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Jan 2021 18:14:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8 Jan 8 Jan

5:28 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49138 )

Change subject: mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig ......................................................................

mb/clevo/cml-u: Drop VGA_BIOS_FILE from Kconfig

It doesn't make sense to configure that filename in Kconfig, since the filename can be changed by the user. So remove it.

Change-Id: I3eed05637da29096bc1d134505d7335db5db1439 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/49138 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/clevo/cml-u/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved

-config VGA_BIOS_FILE - string - default "pci8086,9b41.rom" - config VGA_BIOS_ID string default "8086,9b41"

-- To view, visit https://review.coreboot.org/c/coreboot/+/49138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eed05637da29096bc1d134505d7335db5db1439 Gerrit-Change-Number: 49138 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1241

days inactive

1243

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Felix Singer (Code Review)
Michael Niewöhner (Code Review)
Patrick Georgi (Code Review)