Marco Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48791 )
Change subject: ec/google/chromeec: add SSFC CBI support ......................................................................
ec/google/chromeec: add SSFC CBI support
An API is added to get SSFC value from cros EC.
BUG=b:174118027 BRANCH=octopus TEST=check SSFC value from EC is correct compared to value in CBI
Change-Id: Ifd521514bbc2e90c789f3760b72e8326e614e2b1 --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/48791/1
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index ed7f97d..fdbe582 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -863,6 +863,11 @@ return cbi_get_uint32(version, CBI_TAG_BOARD_VERSION); }
+int google_chromeec_cbi_get_ssfc(uint32_t *ssfc) +{ + return cbi_get_uint32(ssfc, CBI_TAG_SSFC); +} + static int cbi_get_string(char *buf, size_t bufsize, uint32_t tag) { struct ec_params_get_cbi params = { diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index c3c456f..7c41f04 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -89,6 +89,7 @@ /* version may be stored in CBI as a smaller integer width, but the EC code handles it correctly. */ int google_chromeec_cbi_get_board_version(uint32_t *version); +int google_chromeec_cbi_get_ssfc(uint32_t *ssfc);
#define CROS_SKU_UNKNOWN 0xFFFFFFFF #define CROS_SKU_UNPROVISIONED 0x7FFFFFFF
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48791
to look at the new patch set (#2).
Change subject: ec/google/chromeec: add SSFC CBI support ......................................................................
ec/google/chromeec: add SSFC CBI support
An API is added to get SSFC value from cros EC.
BUG=b:174118027 BRANCH=octopus TEST=check SSFC value from EC is correct compared to value in CBI
Change-Id: Ifd521514bbc2e90c789f3760b72e8326e614e2b1 Signed-off-by: Marco Chen marcochen@google.com --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/48791/2
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48791 )
Change subject: ec/google/chromeec: add SSFC CBI support ......................................................................
Patch Set 2:
SSFC was leveraged into EC of Octopus firmware branch for second sources integration and plan to use by coreboot of Octopus firmware branch as awell.
Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48791 )
Change subject: ec/google/chromeec: add SSFC CBI support ......................................................................
Patch Set 2: Code-Review+1
I don't have +2 rights, but LGTM
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48791 )
Change subject: ec/google/chromeec: add SSFC CBI support ......................................................................
Patch Set 2: Code-Review+2
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48791 )
Change subject: ec/google/chromeec: add SSFC CBI support ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: The failure was caused by "ERROR: Step ?Delete workspace when build is done? failed: no workspace for coreboot-gerrit #158124 Finished: FAILURE" so seems to from my CL. As a result, how should I ask for re-verify by Jenkins? Thanks.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48791 )
Change subject: ec/google/chromeec: add SSFC CBI support ......................................................................
ec/google/chromeec: add SSFC CBI support
An API is added to get SSFC value from cros EC.
BUG=b:174118027 BRANCH=octopus TEST=check SSFC value from EC is correct compared to value in CBI
Change-Id: Ifd521514bbc2e90c789f3760b72e8326e614e2b1 Signed-off-by: Marco Chen marcochen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48791 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jett Rink jettrink@google.com Reviewed-by: Zhuohao Lee zhuohao@chromium.org --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Zhuohao Lee: Looks good to me, approved Jett Rink: Looks good to me, but someone else must approve
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 26c6054..0915833 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -863,6 +863,11 @@ return cbi_get_uint32(version, CBI_TAG_BOARD_VERSION); }
+int google_chromeec_cbi_get_ssfc(uint32_t *ssfc) +{ + return cbi_get_uint32(ssfc, CBI_TAG_SSFC); +} + static int cbi_get_string(char *buf, size_t bufsize, uint32_t tag) { struct ec_params_get_cbi params = { diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index c3c456f..7c41f04 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -89,6 +89,7 @@ /* version may be stored in CBI as a smaller integer width, but the EC code handles it correctly. */ int google_chromeec_cbi_get_board_version(uint32_t *version); +int google_chromeec_cbi_get_ssfc(uint32_t *ssfc);
#define CROS_SKU_UNKNOWN 0xFFFFFFFF #define CROS_SKU_UNPROVISIONED 0x7FFFFFFF
-
Jett Rink (Code Review) -
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Zhuohao Lee (Code Review)