[M] Change in coreboot[master]: mb/asus/p8x7x-series: Refactor mainboard_get_spd() - coreboot-gerrit

3 Jan 2023


      Attention is currently required from: Arthur Heymans, Keith Hui.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61540 )
Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd()
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/asus/p8x7x-series/early_init.c:
https://review.coreboot.org/c/coreboot/+/61540/comment/282879cb_a249da9e 
PS3, Line 5: void __weak
nit: We usually put `__weak` at the start
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b9c616a6c722e1f0fc124ced225efdcadb46b25
Gerrit-Change-Number: 61540
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Comment-Date: Tue, 03 Jan 2023 06:46:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment