Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52011 )
Change subject: coreboot_tables: Print strapping IDs when adding them to coreboot table
......................................................................
Patch Set 1:
(2 comments)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/52011/comment/9c35e40f_626a1adc
PS1, Line 308: uint64_t fw_config = fw_config_get();
nit: const
Done
https://review.coreboot.org/c/coreboot/+/52011/comment/9bf40c7e_2bf3e47d
PS1, Line 321: llx
PRIx64
As far as I'm aware we don't consider these mandatory in coreboot (they're hardcoded to the same values for all archs anyway), but fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdbfdd29d25a0937c27113ace776f7aec231a57d
Gerrit-Change-Number: 52011
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 02 Apr 2021 00:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment