Attention is currently required from: Varshit Pandya.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78221?usp=email )
Change subject: soc/amd/genoa: Add SMI support
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/genoa/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/78221/comment/2d52232c_b0e820bb :
PS1, Line 8: /* @Todo: Update the SMI details for Genoa */
Any reason this is left as a TODO instead of doing it before the patch is submitted?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78221?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I491f4075cef8976e4b0762752c9e2e3c2ef886d5
Gerrit-Change-Number: 78221
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Comment-Date: Wed, 04 Oct 2023 15:34:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment