Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Aseda Aboagye, Werner Zeh, Paul Fagerburg, Karthik Ramasubramanian, Felix Held.
Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60849 )
Change subject: Revert "mb/google/dedede/var/beadrix: Remove SD controller"
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60849/comment/b1d77244_623acda3
PS3, Line 11: depthcharge change
Is there one planned?
Done
https://review.coreboot.org/c/coreboot/+/60849/comment/bb77c344_28afc1e4
PS3, Line 11: It makes cret can't boot to os without depthcharge change.
What is the exact error?
...
Starting depthcharge on Beadrix...
src/vboot/util/flag.c:50 flag_install(): Gpio already set up for flag 5.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5e76fc78a56d30caf9f805a8a430f176a653bbe
Gerrit-Change-Number: 60849
Gerrit-PatchSet: 4
Gerrit-Owner: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 07 Jan 2022 13:20:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment