[M] Change in coreboot[main]: soc/amd/*/memmap: factor out common read_lower_soc_memmap_resources - coreboot-gerrit

22 Mar 2024


      Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81389?usp=email )
Change subject: soc/amd/*/memmap: factor out common read_lower_soc_memmap_resources
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81389/comment/1da0da66_0a5f235b :
PS1, Line 11: lower
...
does 'lower' here imply <4GB, or something else?
no, not < 4 GiB, but more specifically <= cbmem_top. didn't find a better name, so i added comments in the code. if you think i should also add that to the commit message, i'll do that
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81389?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id64462b97d144ccdf78ebb051d82a4aa37f8ee98
Gerrit-Change-Number: 81389
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 22 Mar 2024 18:30:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment