Change in coreboot[master]: soc/intel/common/pmc.c Don't implement a weak function that dies
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47752 )
Change subject: soc/intel/common/pmc.c Don't implement a weak function that dies ......................................................................
soc/intel/common/pmc.c Don't implement a weak function that dies
Buildtime failures are better than runtime failures.
Change-Id: I5fe4c86a13dbabb839977010f129419e337e8281 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/pmc/pmc.c 1 file changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/47752/1
diff --git a/src/soc/intel/common/block/pmc/pmc.c b/src/soc/intel/common/block/pmc/pmc.c index 5bfad71..c11ba79 100644 --- a/src/soc/intel/common/block/pmc/pmc.c +++ b/src/soc/intel/common/block/pmc/pmc.c @@ -9,16 +9,6 @@ #include <intelblocks/pmc.h> #include <soc/pci_devs.h>
-/* SoC overrides */ - -/* Fill up PMC resource structure inside SoC directory */ -__weak int pmc_soc_get_resources( - struct pmc_resource_config *cfg) -{ - /* no-op */ - return -1; -} - /* SoC override PMC initialization */ __weak void pmc_soc_init(struct device *dev) {
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47752 )
Change subject: soc/intel/common/pmc.c Don't implement a weak function that dies ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47752 )
Change subject: soc/intel/common/pmc.c Don't implement a weak function that dies ......................................................................
Patch Set 1:
So 151 devices would be bricked if this device was actually discoverable...
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47752
to look at the new patch set (#2).
Change subject: soc/intel/common/pmc.c Don't implement a weak function that dies ......................................................................
soc/intel/common/pmc.c Don't implement a weak function that dies
Buildtime failures are better than runtime failures.
Change-Id: I5fe4c86a13dbabb839977010f129419e337e8281 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/pmc/pmc.c 1 file changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/47752/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47752 )
Change subject: soc/intel/common/pmc.c Don't implement a weak function that dies ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47752 )
Change subject: soc/intel/common/pmc.c Don't implement a weak function that dies ......................................................................
soc/intel/common/pmc.c Don't implement a weak function that dies
Buildtime failures are better than runtime failures.
Change-Id: I5fe4c86a13dbabb839977010f129419e337e8281 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/47752 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/common/block/pmc/pmc.c 1 file changed, 0 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/common/block/pmc/pmc.c b/src/soc/intel/common/block/pmc/pmc.c index d153bc7..fe4dca6 100644 --- a/src/soc/intel/common/block/pmc/pmc.c +++ b/src/soc/intel/common/block/pmc/pmc.c @@ -8,22 +8,6 @@ #include <intelblocks/pmc.h> #include <soc/pci_devs.h>
-/* SoC overrides */ - -/* Fill up PMC resource structure inside SoC directory */ -__weak int pmc_soc_get_resources( - struct pmc_resource_config *cfg) -{ - /* no-op */ - return -1; -} - -/* SoC override PMC initialization */ -__weak void pmc_soc_init(struct device *dev) -{ - /* no-op */ -} - static void pch_pmc_add_new_resource(struct device *dev, uint8_t offset, uintptr_t base, size_t size, unsigned long flags)
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Georgi (Code Review)