Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51397 )
Change subject: soc/intel/alderlake: add processor power limits control support
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51397/comment/7c8781e7_ed4659c4
PS1, Line 14: test
What was tested?
Verified these PL1 and PL2 values using corbeoot logs.
File src/soc/intel/alderlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/51397/comment/081f246b_3e2eaa70
PS1, Line 63: Configure turbo power limits 1ms after reset complete bit
Is this captured in the BWG?
This delay time is coming as legacy on IA. It's captured in document 619503 mentioned in this file header under package power register.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51397
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc37c7a43e6bd6f1ff5e8a97e22a0c7ac421802
Gerrit-Change-Number: 51397
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 11 Mar 2021 05:40:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment