Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37860 )
Change subject: soc/broadwell/minihd: correct vendor, subsystem IDs ......................................................................
soc/broadwell/minihd: correct vendor, subsystem IDs
Codec vendor ID was copy/pasted from Haswell, should be 0x80862808.Subsystem ID for Intel mini-HD is always 0x80860101
Change-Id: Idf4446d3437de0dc533baa3b2b4eb49f816807a6 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/broadwell/minihd.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/37860/1
diff --git a/src/soc/intel/broadwell/minihd.c b/src/soc/intel/broadwell/minihd.c index 2e987bd..40c2571 100644 --- a/src/soc/intel/broadwell/minihd.c +++ b/src/soc/intel/broadwell/minihd.c @@ -27,8 +27,8 @@
static const u32 minihd_verb_table[] = { /* coreboot specific header */ - 0x80862807, // Codec Vendor / Device ID: Intel Mini-HD - 0x00000000, // Subsystem ID + 0x80862808, // Codec Vendor / Device ID: Intel Broadwell Mini-HD + 0x80860101, // Subsystem ID 0x00000004, // Number of jacks
/* Enable 3rd Pin and Converter Widget */
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37860 )
Change subject: soc/broadwell/minihd: correct vendor, subsystem IDs ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
What about Haswell laptops using Broadwell code? I'm not sure if this usecase exists, but it would be worth checking.
https://review.coreboot.org/c/coreboot/+/37860/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37860/1//COMMIT_MSG@10 PS1, Line 10: . Missing space after period, and period at the end.
https://review.coreboot.org/c/coreboot/+/37860/1//COMMIT_MSG@10 PS1, Line 10: mini Mini
Hello Patrick Rudolph, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37860
to look at the new patch set (#2).
Change subject: soc/broadwell/minihd: correct vendor, subsystem IDs ......................................................................
soc/broadwell/minihd: correct vendor, subsystem IDs
Codec vendor ID was copy/pasted from Haswell, should be 0x80862808. Subsystem ID for Intel Mini-HD is always 0x80860101.
Change-Id: Idf4446d3437de0dc533baa3b2b4eb49f816807a6 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/broadwell/minihd.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/37860/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37860 )
Change subject: soc/broadwell/minihd: correct vendor, subsystem IDs ......................................................................
Patch Set 2:
(2 comments)
Patch Set 1: Code-Review+1
What about Haswell laptops using Broadwell code? I'm not sure if this usecase exists, but it would be worth checking.
there's none in the tree, so...
https://review.coreboot.org/c/coreboot/+/37860/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37860/1//COMMIT_MSG@10 PS1, Line 10: mini
Mini
Done
https://review.coreboot.org/c/coreboot/+/37860/1//COMMIT_MSG@10 PS1, Line 10: .
Missing space after period, and period at the end.
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37860 )
Change subject: soc/broadwell/minihd: correct vendor, subsystem IDs ......................................................................
Patch Set 2: Code-Review+2
Patch Set 2:
(2 comments)
Patch Set 1: Code-Review+1
What about Haswell laptops using Broadwell code? I'm not sure if this usecase exists, but it would be worth checking.
there's none in the tree, so...
Ack
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37860 )
Change subject: soc/broadwell/minihd: correct vendor, subsystem IDs ......................................................................
soc/broadwell/minihd: correct vendor, subsystem IDs
Codec vendor ID was copy/pasted from Haswell, should be 0x80862808. Subsystem ID for Intel Mini-HD is always 0x80860101.
Change-Id: Idf4446d3437de0dc533baa3b2b4eb49f816807a6 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37860 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/broadwell/minihd.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/minihd.c b/src/soc/intel/broadwell/minihd.c index 2e987bd..40c2571 100644 --- a/src/soc/intel/broadwell/minihd.c +++ b/src/soc/intel/broadwell/minihd.c @@ -27,8 +27,8 @@
static const u32 minihd_verb_table[] = { /* coreboot specific header */ - 0x80862807, // Codec Vendor / Device ID: Intel Mini-HD - 0x00000000, // Subsystem ID + 0x80862808, // Codec Vendor / Device ID: Intel Broadwell Mini-HD + 0x80860101, // Subsystem ID 0x00000004, // Number of jacks
/* Enable 3rd Pin and Converter Widget */
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)