Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79292?usp=email )
Change subject: mb/google/rex/var/deku: Enable LAN0, LAN1
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79292/comment/aafe5cd8_b59e7fb1 :
PS4, Line 9: Add overridetree.cb entry to configure the LAN0 LAN1 devices.
Maybe add an introductory sentence. google/deku is a Chromebox featuring two LAN ports.
Done
File src/mainboard/google/rex/variants/deku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79292/comment/0762781d_e66fe160 :
PS4, Line 72: #PCIE7 LAN1 card
Please add a space after the #.
Done
https://review.coreboot.org/c/coreboot/+/79292/comment/516d66e9_a9804877 :
PS4, Line 87: #PCIE10 LAN0 card
Please add a space after the #.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79292?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8980dabc7f9fc731a2b60c599e1e48c9b11dabb4
Gerrit-Change-Number: 79292
Gerrit-PatchSet: 7
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 29 Nov 2023 22:58:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment