Attention is currently required from: Shelley Chen, Paul Menzel.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70164 )
Change subject: mb/google/herobrine: Mask out upper bits from sku_id() ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/70164/comment/136488e3_6705799d PS2, Line 95: bits pins
https://review.coreboot.org/c/coreboot/+/70164/comment/ea3b6c8e_df46a06d PS2, Line 98: uint32_t sku_bits_mask = 0x1f; I would maybe just make it 0xff to have a cleaner boundary, that way we have some room to add a 4th or 5th pin if need be. It seems intentional that they started adding the extra bits above 8.
-
Julius Werner (Code Review)