Attention is currently required from: Raul Rangel, Paul Menzel, Mark Hasemeyer.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 )
Change subject: mb/google/myst: Enable chromeOS EC ......................................................................
Patch Set 19:
(2 comments)
File src/mainboard/google/myst/variants/baseboard/include/baseboard/ec.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173676): https://review.coreboot.org/c/coreboot/+/74099/comment/2b8110e1_c15cb4a1 PS19, Line 71: #define SIO_EC_PS2K_IRQ Interrupt (ResourceConsumer, Level, ActiveLow, Shared) {1} space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173676): https://review.coreboot.org/c/coreboot/+/74099/comment/4814d1f2_b17fc1a1 PS19, Line 71: #define SIO_EC_PS2K_IRQ Interrupt (ResourceConsumer, Level, ActiveLow, Shared) {1} Macros with complex values should be enclosed in parentheses