Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37179 )
Change subject: soc/amd/exit_car.S: Drop redundant enabling cache ......................................................................
soc/amd/exit_car.S: Drop redundant enabling cache
This is already done in arch/x86/exit_car.S
Change-Id: Ie954aa11d5e76aaa3e2185ba552aafe8d075feb6 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/amd/common/block/cpu/car/exit_car.S 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/37179/1
diff --git a/src/soc/amd/common/block/cpu/car/exit_car.S b/src/soc/amd/common/block/cpu/car/exit_car.S index f9d056e..16880e7 100644 --- a/src/soc/amd/common/block/cpu/car/exit_car.S +++ b/src/soc/amd/common/block/cpu/car/exit_car.S @@ -29,9 +29,4 @@
AMD_DISABLE_STACK
- /* enable cache */ - movl %cr0, %eax - andl $(~(CR0_CD | CR0_NW)), %eax - movl %eax, %cr0 - jmp *%esp
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37179 )
Change subject: soc/amd/exit_car.S: Drop redundant enabling cache ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37179 )
Change subject: soc/amd/exit_car.S: Drop redundant enabling cache ......................................................................
soc/amd/exit_car.S: Drop redundant enabling cache
This is already done in arch/x86/exit_car.S
Change-Id: Ie954aa11d5e76aaa3e2185ba552aafe8d075feb6 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37179 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/cpu/car/exit_car.S 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/common/block/cpu/car/exit_car.S b/src/soc/amd/common/block/cpu/car/exit_car.S index f9d056e..16880e7 100644 --- a/src/soc/amd/common/block/cpu/car/exit_car.S +++ b/src/soc/amd/common/block/cpu/car/exit_car.S @@ -29,9 +29,4 @@
AMD_DISABLE_STACK
- /* enable cache */ - movl %cr0, %eax - andl $(~(CR0_CD | CR0_NW)), %eax - movl %eax, %cr0 - jmp *%esp
-
Arthur Heymans (Code Review) -
Marshall Dawson (Code Review)
-
Patrick Georgi (Code Review)