Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46620 )
Change subject: mb/google/poppy/v/atlas: Reset bluetooth during boot ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46620/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/atlas/gpio.c:
https://review.coreboot.org/c/coreboot/+/46620/4/src/mainboard/google/poppy/... PS4, Line 198: DEEP What is the default state of GPP_E2? And is there an internal or external pull down on this line?
If yes, then there is no additional work required to meet the timing. Configuring as DEEP ensures that the pad gets reset on any kind of reset (except S3/S4/S5). With default internal or external pull, BT_DISABLE_L will be pulled down and since this configuration happens in ramstage, it is guaranteed that you meet the 170ms+ of reset assertion.
-
Furquan Shaikh (Code Review)