Change in coreboot[master]: option: Add API for mainboard provided options - coreboot-gerrit

3 May 2021


      Attention is currently required from: Bill XIE, Nico Huber, Christian Walter, Angel Pons, Julius Werner, Kyösti Mälkki.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52601 )
Change subject: option: Add API for mainboard provided options
......................................................................
Patch Set 4:
(1 comment)
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/52601/comment/ee2898cf_bc72eac9 
PS1, Line 21: mainboard_set_option
...
I don't think adding a weak function for this is a good idea. […]
Implemented a stub driver which is compiled in when USE_NO_OPTION_TABLE is selected.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52601
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5bbb5b3353d862c5533f90ced4824eec27ca3b9
Gerrit-Change-Number: 52601
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Bill XIE persmule@hardenedlinux.org
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bill XIE persmule@hardenedlinux.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 03 May 2021 14:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Walter christian.walter@9elements.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment