Attention is currently required from: Jonathan Zhang, Simon Chou, Johnny Lin, Christian Walter, David Hendricks, Stefan Reinauer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71943 )
Change subject: util/inteltool: add support for EBG PCH ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
Thanks for the feedback, and sorry about this, Martin. I did not know the TOT is broken. […]
Hey Jonathan, Yes, pushing a few at a time definitely helps. It's generally not even that big of a deal, just unfortunate circumstances in this case with the broken ToT, and then a number of people submitting long trains. As I'm typing this, the build queue is now up to 80 patches, so this definitely isn't the only train at issue.
Here's the section of the document I was referring to:
``` Don’t submit patch trains longer than around 20 patches unless you understand how to manage long patch trains. Long patch trains can become difficult to handle and tie up the build servers for long periods of time if not managed well. Rebasing a patch train over and over as you fix earlier patches in the train can hide comments, and make people review the code multiple times to see if anything has changed between revisions. When pushing long patch trains, it is recommended to only push the full patch train once - the initial time, and only to rebase three or four patches at a time.
Run ‘make what-jenkins-does’ locally on patch trains before submitting. This helps verify that the patch train won’t tie up the jenkins builders for no reason if there are failing patches in the train. For running parallel builds, you can specify the number of cores to use by setting the the CPUS environment variable. Example: make what-jenkins-does CPUS=8 ```
-
Martin L Roth (Code Review)