HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32377
Change subject: ic7/i945: Use full_reset() ......................................................................
ic7/i945: Use full_reset()
For full reset, use already defined full_reset() function.
Change-Id: Iec7dcf285f3cb1cdc8f48d348ff8496879625db5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/32377/1
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index be3d17a..d41b913 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -19,6 +19,7 @@ #include <device/pci_def.h> #include <device/pci_ops.h> #include <arch/io.h> +#include <cf9_reset.h> #include <device/mmio.h> #include <device/device.h> #include <lib.h> @@ -272,9 +273,7 @@
if (do_reset) { printk(BIOS_DEBUG, "Reset required.\n"); - outb(0x00, 0xcf9); - outb(0x0e, 0xcf9); - halt(); /* Wait for reset! */ + full_reset(); } }
@@ -303,9 +302,7 @@
if (do_reset) { printk(BIOS_DEBUG, "Reset required.\n"); - outb(0x00, 0xcf9); - outb(0x0e, 0xcf9); - halt(); /* Wait for reset! */ + full_reset(); } }
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32377
to look at the new patch set (#2).
Change subject: ich7/i945: Use full_reset() ......................................................................
ich7/i945: Use full_reset()
For full reset, use already defined full_reset() function.
Change-Id: Iec7dcf285f3cb1cdc8f48d348ff8496879625db5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/32377/2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32377 )
Change subject: ich7/i945: Use full_reset() ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32377 )
Change subject: ich7/i945: Use full_reset() ......................................................................
ich7/i945: Use full_reset()
For full reset, use already defined full_reset() function.
Change-Id: Iec7dcf285f3cb1cdc8f48d348ff8496879625db5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32377 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/i945/raminit.c 1 file changed, 3 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index be3d17a..d41b913 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -19,6 +19,7 @@ #include <device/pci_def.h> #include <device/pci_ops.h> #include <arch/io.h> +#include <cf9_reset.h> #include <device/mmio.h> #include <device/device.h> #include <lib.h> @@ -272,9 +273,7 @@
if (do_reset) { printk(BIOS_DEBUG, "Reset required.\n"); - outb(0x00, 0xcf9); - outb(0x0e, 0xcf9); - halt(); /* Wait for reset! */ + full_reset(); } }
@@ -303,9 +302,7 @@
if (do_reset) { printk(BIOS_DEBUG, "Reset required.\n"); - outb(0x00, 0xcf9); - outb(0x0e, 0xcf9); - halt(); /* Wait for reset! */ + full_reset(); } }
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)