Attention is currently required from: Martin Roth, Idwer Vollering, Paul Menzel, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56803 )
Change subject: util/genbuild_h: micro-adjust the regexp used to set COREBOOT_MAJOR_VERSION ......................................................................
Patch Set 4: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56803/comment/062d9e96_d4736edd PS3, Line 7: COREBOOT_MAJOR_VERSION
Alternatively, borrow CB:55468 's commit message.
Done
https://review.coreboot.org/c/coreboot/+/56803/comment/4d47d1c2_bc5ad984 PS3, Line 11: will avoid
nit: avoids
Done
https://review.coreboot.org/c/coreboot/+/56803/comment/5332adc8_1eee384c PS3, Line 12:
Please break long lines; line-length limit for commit messages is 72 chars.
Done
File util/genbuild_h/genbuild_h.sh:
https://review.coreboot.org/c/coreboot/+/56803/comment/e09d5c82_1e851d2a PS2, Line 73: printf "#define COREBOOT_MAJOR_VERSION %d\n#define COREBOOT_MINOR_VERSION %d\n" `git describe --match [0-9].[0-9]* | sed 's/([0-9]).([0-9][0-9]*).*/\1 \2/'`
CB:55468 says that + is not part of POSIX Basic Regular Expressions.
Done