Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69878 )
Change subject: sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
git grep "define.*TCO1_CNT"
src/southbridge/intel/common/pmutil.h:#define TCO1_CNT 0x68
src/southbridge/intel/common/tco.h:#define TCO1_CNT 0x08
The way the offsets are currently used if one big mess.
TCO fixes are part of bigger changeset to replace a lot of inw/out() with bitwise operations in the ACPI PM register space:
https://review.coreboot.org/c/coreboot/+/69760/5/src/southbridge/intel/i8280...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id281a3478051c4876ccbe26452d8744769c86654
Gerrit-Change-Number: 69878
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 25 Nov 2022 04:28:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment