Change in coreboot[master]: console,boot_state: Denote unit in beginning in log message

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38136 )


Change subject: console,boot_state: Denote unit in beginning in log message
......................................................................

console,boot_state: Denote unit in beginning in log message

Looking at the board status repository logs, lines similar to

    BS: postcar times (exec / console): total (unknown) / 0 ms

    BS: BS_DEV_ENUMERATE run times (exec / console): 6 / 0 ms

are not obvious right away, as the unit visually only applies to the
value after the slash.

So, add the unit after `times`.

    BS: BS_DEV_ENUMERATE run times [ms] (exec / console): 6 / 0

Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Signed-off-by: Paul Menzel <[e-mail]>
---
M src/console/printk.c
M src/lib/hardwaremain.c
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/38136/1

diff --git a/src/console/printk.c b/src/console/printk.c
index 3ef28f3..be7c98b 100644
--- a/src/console/printk.c
+++ b/src/console/printk.c
@@ -49,7 +49,7 @@
 	if (!TRACK_CONSOLE_TIME)
 		return;
 
-	printk(BIOS_DEBUG, "BS: " ENV_STRING " times (exec / console): total (unknown) / %ld ms\n",
+	printk(BIOS_DEBUG, "BS: " ENV_STRING " times [ms] (exec / console): total (unknown) / %ld\n",
 		DIV_ROUND_CLOSEST(console_usecs, USECS_PER_MSEC));
 }
 
diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c
index eba5f12..cf1e1b7 100644
--- a/src/lib/hardwaremain.c
+++ b/src/lib/hardwaremain.c
@@ -250,7 +250,7 @@
 		execution = DIV_ROUND_CLOSEST(execution, USECS_PER_MSEC);
 		console = DIV_ROUND_CLOSEST(console, USECS_PER_MSEC);
 		if (execution) {
-			printk(BIOS_DEBUG, "BS: %s %s times (exec / console): %ld / %ld ms\n",
+			printk(BIOS_DEBUG, "BS: %s %s times [ms] (exec / console): %ld / %ld\n",
 				state->name, sample_id[i], execution - console, console);
 			/* Reset again to ignore printk() time above. */
 			console_time_get_and_reset();

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Gerrit-Change-Number: 38136
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <[e-mail]>
Gerrit-MessageType: newchange

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38136 )

Change subject: console,boot_state: Denote unit in beginning in log message
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38136/1/src/console/printk.c 
File src/console/printk.c:

https://review.coreboot.org/c/coreboot/+/38136/1/src/console/printk.c@52 
PS1, Line 52: 	printk(BIOS_DEBUG, "BS: " ENV_STRING " times [ms] (exec / console): total (unknown) / %ld\n",
line over 96 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Gerrit-Change-Number: 38136
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <[e-mail]>
Gerrit-CC: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Thu, 02 Jan 2020 13:38:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38136 )

Change subject: console,boot_state: Denote unit in beginning in log message
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38136/1/src/console/printk.c 
File src/console/printk.c:

https://review.coreboot.org/c/coreboot/+/38136/1/src/console/printk.c@52 
PS1, Line 52: 	printk(BIOS_DEBUG, "BS: " ENV_STRING " times [ms] (exec / console): total (unknown) / %ld\n",
> line over 96 characters
> I think you can split after `BIOS_DEBUG`, and it should fit in 96 chars

[Paul Menzel (Code Review)]

Hello Angel Pons, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/38136

to look at the new patch set (#2).

Change subject: console,boot_state: Denote unit in beginning in log message
......................................................................

console,boot_state: Denote unit in beginning in log message

Looking at the board status repository logs, lines similar to

    BS: postcar times (exec / console): total (unknown) / 0 ms

    BS: BS_DEV_ENUMERATE run times (exec / console): 6 / 0 ms

are not obvious right away, as the unit visually only applies to the
value after the slash.

So, add the unit after `times`.

    BS: BS_DEV_ENUMERATE run times [ms] (exec / console): 6 / 0

Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Signed-off-by: Paul Menzel <[e-mail]>
---
M src/console/printk.c
M src/lib/hardwaremain.c
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/38136/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Gerrit-Change-Number: 38136
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38136 )

Change subject: console,boot_state: Denote unit in beginning in log message
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38136/2/src/console/printk.c 
File src/console/printk.c:

https://review.coreboot.org/c/coreboot/+/38136/2/src/console/printk.c@52 
PS2, Line 52: 	printk(BIOS_DEBUG, "BS: " ENV_STRING " times [ms] (exec / console): total (unknown) / %ld\n",
line over 96 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Gerrit-Change-Number: 38136
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Tue, 07 Jan 2020 17:43:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Paul Menzel (Code Review)]

Hello Angel Pons, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/38136

to look at the new patch set (#3).

Change subject: console,boot_state: Denote unit in beginning in log message
......................................................................

console,boot_state: Denote unit in beginning in log message

Looking at the board status repository logs, lines similar to

    BS: postcar times (exec / console): total (unknown) / 0 ms

    BS: BS_DEV_ENUMERATE run times (exec / console): 6 / 0 ms

are not obvious right away, as the unit visually only applies to the
value after the slash.

So, add the unit after `times`.

    BS: BS_DEV_ENUMERATE run times [ms] (exec / console): 6 / 0

Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Signed-off-by: Paul Menzel <[e-mail]>
---
M src/console/printk.c
M src/lib/hardwaremain.c
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/38136/3
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Gerrit-Change-Number: 38136
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38136 )

Change subject: console,boot_state: Denote unit in beginning in log message
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38136/1/src/console/printk.c 
File src/console/printk.c:

https://review.coreboot.org/c/coreboot/+/38136/1/src/console/printk.c@52 
PS1, Line 52: 	printk(BIOS_DEBUG, "BS: " ENV_STRING " times [ms] (exec / console): total (unknown) / %ld\n",
> I think you can split after `BIOS_DEBUG`, and it should fit in 96 chars
> Done

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38136 )

Change subject: console,boot_state: Denote unit in beginning in log message
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Gerrit-Change-Number: 38136
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 25 Mar 2020 20:26:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[XS] Change in coreboot[master]: console,boot_state: Denote unit in beginning in log message

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38136?usp=email )

Change subject: console,boot_state: Denote unit in beginning in log message
......................................................................


Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38136?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Gerrit-Change-Number: 38136
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Martin L Roth <[e-mail]>
Gerrit-MessageType: abandon