Paul Menzel has uploaded this change for review.

View Change

console,boot_state: Denote unit in beginning in log message

Looking at the board status repository logs, lines similar to

    BS: postcar times (exec / console): total (unknown) / 0 ms

    BS: BS_DEV_ENUMERATE run times (exec / console): 6 / 0 ms

are not obvious right away, as the unit visually only applies to the
value after the slash.

So, add the unit after `times`.

    BS: BS_DEV_ENUMERATE run times [ms] (exec / console): 6 / 0

Change-Id: If01a5d43a54aeefc0a6d49d4b600436c2a8328cd
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
M src/console/printk.c
M src/lib/hardwaremain.c
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/38136/1

diff --git a/src/console/printk.c b/src/console/printk.c
index 3ef28f3..be7c98b 100644
--- a/src/console/printk.c
+++ b/src/console/printk.c
@@ -49,7 +49,7 @@
 	if (!TRACK_CONSOLE_TIME)
 		return;
 
-	printk(BIOS_DEBUG, "BS: " ENV_STRING " times (exec / console): total (unknown) / %ld ms\n",
+	printk(BIOS_DEBUG, "BS: " ENV_STRING " times [ms] (exec / console): total (unknown) / %ld\n",
 		DIV_ROUND_CLOSEST(console_usecs, USECS_PER_MSEC));
 }
 
diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c
index eba5f12..cf1e1b7 100644
--- a/src/lib/hardwaremain.c
+++ b/src/lib/hardwaremain.c
@@ -250,7 +250,7 @@
 		execution = DIV_ROUND_CLOSEST(execution, USECS_PER_MSEC);
 		console = DIV_ROUND_CLOSEST(console, USECS_PER_MSEC);
 		if (execution) {
-			printk(BIOS_DEBUG, "BS: %s %s times (exec / console): %ld / %ld ms\n",
+			printk(BIOS_DEBUG, "BS: %s %s times [ms] (exec / console): %ld / %ld\n",
 				state->name, sample_id[i], execution - console, console);
 			/* Reset again to ignore printk() time above. */
 			console_time_get_and_reset();

To view, visit change 38136. To unsubscribe, or for help writing mail filters, visit settings.