Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56676 )
Change subject: soc/amd/common/block/acpimmio: add remote GPIO bank access helpers
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/acpimmio.h:
https://review.coreboot.org/c/coreboot/+/56676/comment/f7bf2297_4411d945
PS3, Line 347: offset from the first remote GPIO which is GPIO 256
Is there a good reason to do this vs. […]
i'd say that the parameter being the offset in 32 byte registers into the remote GPIO MMIO region is less unexpected than the MMIO access function subtracting 256 from the parameter which makes it easy to use the functions wrongly, since calling it with a parameter < 256 would result in rather unexpected behavior compared how the rest of the functions in here behave
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56676
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice4e3358de17ac2601621814978cdb70e6f2c926
Gerrit-Change-Number: 56676
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Fri, 30 Jul 2021 23:41:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment