Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56166 )
Change subject: soc/mediatek/mt8195: fine tune pmif spi hardware settings for stability ......................................................................
soc/mediatek/mt8195: fine tune pmif spi hardware settings for stability
Update IO driving setting for pmif spi.
Signed-off-by: James Lo james.lo@mediatek.corp-partner.google.com Change-Id: I48268cda8845a591592d8ca828ffe492e6dfe0ce --- M src/soc/mediatek/mt8195/include/soc/iocfg.h M src/soc/mediatek/mt8195/pmif_spi.c 2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/56166/1
diff --git a/src/soc/mediatek/mt8195/include/soc/iocfg.h b/src/soc/mediatek/mt8195/include/soc/iocfg.h index 8ca2f62..f3524dc 100644 --- a/src/soc/mediatek/mt8195/include/soc/iocfg.h +++ b/src/soc/mediatek/mt8195/include/soc/iocfg.h @@ -63,5 +63,6 @@
enum { IO_4_MA = 0x9, + IO_6_MA = 0x1b, }; #endif /* __SOC_MEDIATEK_MT8195_IOCFG_H__ */ diff --git a/src/soc/mediatek/mt8195/pmif_spi.c b/src/soc/mediatek/mt8195/pmif_spi.c index ddb2175..eff4a21 100644 --- a/src/soc/mediatek/mt8195/pmif_spi.c +++ b/src/soc/mediatek/mt8195/pmif_spi.c @@ -10,7 +10,7 @@
void pmif_spi_iocfg(void) { - /* Set SoC SPI IO driving strength to 4 mA */ - SET32_BITFIELDS(&mtk_iocfg_bm->drv_cfg1, PWRAP_SPI0_DRIVING, IO_4_MA); - SET32_BITFIELDS(&mtk_iocfg_bm->drv_cfg2, PWRAP_SPI1_DRIVING, IO_4_MA); + /* Set SoC SPI IO driving strength to 6 mA */ + SET32_BITFIELDS(&mtk_iocfg_bm->drv_cfg1, PWRAP_SPI0_DRIVING, IO_6_MA); + SET32_BITFIELDS(&mtk_iocfg_bm->drv_cfg2, PWRAP_SPI1_DRIVING, IO_6_MA); }