Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29875 )
Change subject: sb/intel: Fix pointer casts ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29875/2/src/southbridge/intel/i82801ix/lpc.c File src/southbridge/intel/i82801ix/lpc.c:
https://review.coreboot.org/#/c/29875/2/src/southbridge/intel/i82801ix/lpc.c... PS2, Line 556: acpigen_write_name_dword
is this really writing out a 64bit pointer when compiled for 64bit? Or is this just enough to get th […]
NVSA is still 32bit. The whole 64bit pointer to uint32_t doesn't matter that much, as all functions allocate memory below 4GiB and all code is loaded below 4GiB.
I thought about a macro that does the cast and asserts if the high bits are set. Is this what you had in mind ?
This is about getting basic support for x86_64 in qemu. Running code or allocating memory beyond 4GiB on real hardware is still a long way.
-
Patrick Rudolph (Code Review)