Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80923?usp=email )
Change subject: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry ......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/cse/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/80923/comment/3a4d3f4d_e0453a6a : PS1, Line 101: $(eval $(word $(index),$(VERSIONS)) := $(shell printf "%d" 0x$(shell echo $(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c3-4)$(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c1-2))) )
Does this still support version number parts that contains more than two digits? Intel tends to use build numbers (last version entry) that are 4 digits long.
This is as per the ME specification where CSE major/minor/hotfix/build all are 2 byte long.
https://review.coreboot.org/c/coreboot/+/80923/comment/ab1c94b5_3834b1f8 : PS1, Line 103: TEMP_FILE
Shouldn't this be TEMP_DATA? Or, if you insist on TEMP_FILE (which I find a better name), then you s […]
Acknowledged