Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81342?usp=email )
Change subject: vc/amd/opensil/genoa_poc/mpio: use device status for port_present ......................................................................
vc/amd/opensil/genoa_poc/mpio: use device status for port_present
Only report the port as present in the MPIO_PORT_DATA_INITIALIZER_PCIE macro parameter when the device is enabled; otherwise report the port as disabled.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ieaa2af6c5ff3fc7e25992e7fdf14d37ee4a57d62 Reviewed-on: https://review.coreboot.org/c/coreboot/+/81342 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Varshit Pandya pandyavarshit@gmail.com --- M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Varshit Pandya: Looks good to me, approved Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c index cae9d4b..2ad10af 100644 --- a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c +++ b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c @@ -157,7 +157,8 @@ config->gpio_group); port.EngineData = engine_data; const MPIO_PORT_DATA port_data = - MPIO_PORT_DATA_INITIALIZER_PCIE(MpioPortEnabled, + MPIO_PORT_DATA_INITIALIZER_PCIE(is_dev_enabled(dev) ? + MpioPortEnabled : MpioPortDisabled, PCI_SLOT(devfn), PCI_FUNC(devfn), config->hotplug,