build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53903 )
Change subject: libpayload: Add MMIO support in PCI lib ......................................................................
Patch Set 1:
(5 comments)
File payloads/libpayload/include/arm64/arch/io.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118692): https://review.coreboot.org/c/coreboot/+/53903/comment/4d884ec5_b6031d67 PS1, Line 154: } void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118692): https://review.coreboot.org/c/coreboot/+/53903/comment/a2337465_05c4f2a9 PS1, Line 159: } void function return statements are not generally useful
File src/commonlib/include/commonlib/coreboot_tables.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118692): https://review.coreboot.org/c/coreboot/+/53903/comment/70425c3c_9668b313 PS1, Line 332: uint32_t tag; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118692): https://review.coreboot.org/c/coreboot/+/53903/comment/c45b9703_7cfb4669 PS1, Line 333: uint32_t size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118692): https://review.coreboot.org/c/coreboot/+/53903/comment/636a19f1_4534af32 PS1, Line 334: void *config_base; please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)