Attention is currently required from: Andy Hsu, Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85654?usp=email )
Change subject: soc/mediatek/mt8196: Add GPUEB support
......................................................................
Patch Set 4:
(5 comments)
File src/soc/mediatek/mt8196/gpueb.c:
https://review.coreboot.org/c/coreboot/+/85654/comment/22270a58_5c494163?usp... :
PS2, Line 193: void *buf_addr
Done
not done
https://review.coreboot.org/c/coreboot/+/85654/comment/4c846255_af4ad945?usp... :
PS2, Line 289: imgsize
Done
not done
File src/soc/mediatek/mt8196/gpueb.c:
https://review.coreboot.org/c/coreboot/+/85654/comment/af51b844_9868a104?usp... :
PS4, Line 192: Fail
failed
https://review.coreboot.org/c/coreboot/+/85654/comment/e8a985dd_e6e2fe99?usp... :
PS4, Line 196: gpueb_
remove `gpueb_` prefix
https://review.coreboot.org/c/coreboot/+/85654/comment/3e7e4e37_88135a9a?usp... :
PS4, Line 247: auto_dma_fw[pt_id].fw_size <= GPUEB_SRAM_SIZE
`auto_dma_fw[pt_id].fw_addr + auto_dma_fw[pt_id].fw_size <= GPUEB_SRAM_SIZE`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f10dfc753f73df97ea08a4c23e97de416832be2
Gerrit-Change-Number: 85654
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alvin Liu
alvin.liu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 02 Jan 2025 03:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alvin Liu
alvin.liu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com