Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83679?usp=email )
Change subject: soc/inte/{adl,mtl}: Move ASPM helper functions to common
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/aspm/aspm.c:
https://review.coreboot.org/c/coreboot/+/83679/comment/169d6e74_61645c78?usp... :
PS3, Line 73: s_cfg->PcieRpEnableCpm[index] = CONFIG(PCIEXP_CLK_PM);
: s_cfg->PcieRpAspm[index] = aspm_control_to_upd(rp_cfg->pcie_rp_aspm);
: s_cfg->PcieRpL1Substates[index] = l1ss_control_to_upd(rp_cfg->PcieRpL1Substates);
Do you also want to use option API here?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83679?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic6876e920d75abbbbb27d4ce3a4f2c08a8db9410
Gerrit-Change-Number: 83679
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Sat, 28 Dec 2024 20:12:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com