Attention is currently required from: Lance Zhao, Raul Rangel, Martin Roth, Tim Wawrzynczak, Julius Werner.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59504 )
Change subject: acpi,Makefile: Add preload_acpi_dsdt
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
buffering to RAM and writing it all out when the SPI reads are done should work, no? […]
That's what I meant. The "chaining" would be simple if the actions are stored in a sequential buffer: Just always add to the end, then work through them, waiting for one to complete before moving to the next.
But yeah, there's some complication if an operation fails. Or if written data is read again in the same boot (which shouldn't be much of a concern for elog)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59504
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf69ecb947811a2eec861018e3ba5f858155f1c3
Gerrit-Change-Number: 59504
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 22 Nov 2021 16:52:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment