Change in coreboot[master]: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45952 )
Change subject: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45952/17/src/soc/intel/common/block... File src/soc/intel/common/block/pmc/Kconfig:
https://review.coreboot.org/c/coreboot/+/45952/17/src/soc/intel/common/block... PS17, Line 45: is required for ACPI
It sounds like, if you disable the timer, then ACPI stop working?
Well, I'd suggest reading the whole paragraph in context? ;) "[...] Disabling it enables the ACPI timer emulation in microcode."
https://review.coreboot.org/c/coreboot/+/45952/17/src/soc/intel/common/block... PS17, Line 45: TCO
It’d be great, if you spelt it out once.
what for? this is not even done for block/smbus/Kconfig or block/smm/Kconfig
-
Michael Niewöhner (Code Review)