Mariusz Szafrański has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB ......................................................................
MAINTAINERS: update maintainers of INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB
Change-Id: Ifdb24f9566b53af6c23b4cd4adba0c1876e4fc9d Signed-off-by: Mariusz Szafranski mariuszx.szafranski@intel.com --- M MAINTAINERS 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/47753/1
diff --git a/MAINTAINERS b/MAINTAINERS index 1f4df52..79f771d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -506,8 +506,10 @@ F: src/include/cpu/intel/
INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB +M: Suresh Bellampalli suresh.bellampalli@intel.com M: Vanessa Eusebio vanessa.f.eusebio@intel.com -M: David Guckian david.guckian@intel.com +M: Michal Motyl michalx.motyl@intel.com +M: Mariusz Szafranski mariuszx.szafranski@intel.com S: Odd Fixes F: src/mainboard/intel/harcuvar/ F: src/soc/intel/denverton_ns/
Suresh Bellampalli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB ......................................................................
Patch Set 1: Code-Review+1
Michal Motyl has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47753/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47753/1//COMMIT_MSG@7 PS1, Line 7: INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB nit: I'd simply mention "Intel Denverton-NS SoC"
https://review.coreboot.org/c/coreboot/+/47753/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/47753/1/MAINTAINERS@513 PS1, Line 513: Odd Fixes Should this be changed as well? I would suggest "Supported" if someone is continuously paid to look after this and a reaction to review requests can be expected within a few days, a month at most. If that seems too extreme, "Maintained" is also a good choice.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB ......................................................................
Patch Set 1:
Dmitry, please check the updated list for the possible open questions you have on the Denverton-NS FSP builds and the missing questions.
Hello build bot (Jenkins), David Guckian, Suresh Bellampalli, Angel Pons, Michal Motyl, David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47753
to look at the new patch set (#2).
Change subject: MAINTAINERS: update maintainers of Intel Denverton-NS SoC ......................................................................
MAINTAINERS: update maintainers of Intel Denverton-NS SoC
Change-Id: Ifdb24f9566b53af6c23b4cd4adba0c1876e4fc9d Signed-off-by: Mariusz Szafranski mariuszx.szafranski@intel.com --- M MAINTAINERS 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/47753/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of Intel Denverton-NS SoC ......................................................................
Patch Set 2: Code-Review+2
David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of Intel Denverton-NS SoC ......................................................................
Patch Set 2: Code-Review+1
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of Intel Denverton-NS SoC ......................................................................
Patch Set 2: Code-Review+2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of Intel Denverton-NS SoC ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47753/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47753/1//COMMIT_MSG@7 PS1, Line 7: INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB
nit: I'd simply mention "Intel Denverton-NS SoC"
Done
https://review.coreboot.org/c/coreboot/+/47753/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/47753/1/MAINTAINERS@513 PS1, Line 513: Odd Fixes
Should this be changed as well? I would suggest "Supported" if someone is continuously paid to look […]
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of Intel Denverton-NS SoC ......................................................................
Patch Set 2: Code-Review+1
Please ensure, that all maintainers are subscribed to the coreboot mailing list, and will interact with the community.
Mariusz Szafrański has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of Intel Denverton-NS SoC ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
Please ensure, that all maintainers are subscribed to the coreboot mailing list, and will interact with the community.
All already subscribed to the coreboot mailing list. If we miss something just ping me or Suresh.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47753 )
Change subject: MAINTAINERS: update maintainers of Intel Denverton-NS SoC ......................................................................
MAINTAINERS: update maintainers of Intel Denverton-NS SoC
Change-Id: Ifdb24f9566b53af6c23b4cd4adba0c1876e4fc9d Signed-off-by: Mariusz Szafranski mariuszx.szafranski@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47753 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: David Guckian d.guckian20@gmail.com Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M MAINTAINERS 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved David Guckian: Looks good to me, but someone else must approve Christian Walter: Looks good to me, approved
diff --git a/MAINTAINERS b/MAINTAINERS index 6a1f500..1972c88 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -506,9 +506,11 @@ F: src/include/cpu/intel/
INTEL FSP DENVERTON-NS SOC & HARCUVAR CRB +M: Suresh Bellampalli suresh.bellampalli@intel.com M: Vanessa Eusebio vanessa.f.eusebio@intel.com -M: David Guckian david.guckian@intel.com -S: Odd Fixes +M: Michal Motyl michalx.motyl@intel.com +M: Mariusz Szafranski mariuszx.szafranski@intel.com +S: Maintained F: src/mainboard/intel/harcuvar/ F: src/soc/intel/denverton_ns/