Attention is currently required from: Jason Glenesk, Michał Żygowski, Marshall Dawson, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes, Piotr Król, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50718 )
Change subject: mb/: Drop print of MAINBOARD_PART_NUMBER
......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/amd/gardenia/mainboard.c:
https://review.coreboot.org/c/coreboot/+/50718/comment/d68be12e_823eed3f
PS1, Line 3: include <console/console.h>
mabe not used ?
I have stuff to bring back into these files really soon.
File src/mainboard/amd/inagua/mainboard.c:
https://review.coreboot.org/c/coreboot/+/50718/comment/416317a9_2f00b4c9
PS1, Line 4: include <console/console.h>
maybe not used anymore
Ack
File src/mainboard/amd/majolica/mainboard.c:
https://review.coreboot.org/c/coreboot/+/50718/comment/f60a4c22_d25361e4
PS1, Line 5: #include <console/console.h>
maybe not used
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50718
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3870bc666acaea316f00b205de512cf790e720c
Gerrit-Change-Number: 50718
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 15 Feb 2021 11:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment