Change in coreboot[master]: soc/intel/apollolake: set FSP param to enable or skip GOP

[Michael Niewöhner (Code Review)]

Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36352 )

Change subject: soc/intel/apollolake: set FSP param to enable or skip GOP
......................................................................

soc/intel/apollolake: set FSP param to enable or skip GOP

Set the FSP parameter PeiGraphicsPeimInit according to RUN_FSP_GOP to
enable or skip GOP.

Change-Id: I3546371dd18120e3fbd1179a79b2bdc0a7436726
Signed-off-by: Michael Niewöhner 
---
M src/soc/intel/apollolake/chip.c
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/36352/1

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 8e516f8..c66ca85 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -751,6 +751,13 @@
    /* Set VTD feature according to devicetree */
    silconfig->VtdEnable = cfg->enable_vtd;

+	/* Only initialize graphics if supported and enabled */
+	dev = pcidev_path_on_root(SA_DEVFN_IGD);
+	if (CONFIG(RUN_FSP_GOP) && dev && dev->enabled)
+		params->PeiGraphicsPeimInit = 1;
+	else
+		params->PeiGraphicsPeimInit = 0;
+
    mainboard_silicon_init_params(silconfig);
 }

[Michael Niewöhner (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36352

to look at the new patch set (#2).

Change subject: soc/intel/apollolake: set FSP param to enable or skip GOP
......................................................................

soc/intel/apollolake: set FSP param to enable or skip GOP

Set the FSP parameter PeiGraphicsPeimInit according to RUN_FSP_GOP to
enable or skip GOP.

Change-Id: I3546371dd18120e3fbd1179a79b2bdc0a7436726
Signed-off-by: Michael Niewöhner 
---
M src/soc/intel/apollolake/chip.c
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/36352/2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36352 )

Change subject: soc/intel/apollolake: set FSP param to enable or skip GOP
......................................................................

Uploaded patch set 2.

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36352 )

Change subject: soc/intel/apollolake: set FSP param to enable or skip GOP
......................................................................

Patch Set 2: Code-Review+2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36352 )

Change subject: soc/intel/apollolake: set FSP param to enable or skip GOP
......................................................................

Uploaded patch set 3.

[Michael Niewöhner (Code Review)]

Hello Naresh Solanki, Kyösti Mälkki, Patrick Rudolph, Subrata Banik, Tristan Corrick, Paul Menzel, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Maxim Polyakov, Nico Huber, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36352

to look at the new patch set (#3).

Change subject: soc/intel/apollolake: set FSP param to enable or skip GOP
......................................................................

soc/intel/apollolake: set FSP param to enable or skip GOP

Set the FSP parameter PeiGraphicsPeimInit according to RUN_FSP_GOP to
enable or skip GOP.

Change-Id: I3546371dd18120e3fbd1179a79b2bdc0a7436726
Signed-off-by: Michael Niewöhner 
---
M src/soc/intel/apollolake/chip.c
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/36352/3

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36352 )

Change subject: soc/intel/apollolake: set FSP param to enable or skip GOP
......................................................................

Patch Set 3: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36352 )

Change subject: soc/intel/apollolake: set FSP param to enable or skip GOP
......................................................................

soc/intel/apollolake: set FSP param to enable or skip GOP

Set the FSP parameter PeiGraphicsPeimInit according to RUN_FSP_GOP to
enable or skip GOP.

Change-Id: I3546371dd18120e3fbd1179a79b2bdc0a7436726
Signed-off-by: Michael Niewöhner 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36352
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
---
M src/soc/intel/apollolake/chip.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 8e516f8..1aab8a1 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -751,6 +751,12 @@
    /* Set VTD feature according to devicetree */
    silconfig->VtdEnable = cfg->enable_vtd;

+	dev = pcidev_path_on_root(SA_DEVFN_IGD);
+	if (CONFIG(RUN_FSP_GOP) && dev && dev->enabled)
+		silconfig->PeiGraphicsPeimInit = 1;
+	else
+		silconfig->PeiGraphicsPeimInit = 0;
+
    mainboard_silicon_init_params(silconfig);
 }