Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32389 )
Change subject: mb/google/sarien: Add SMBIOS type 9 fields
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32389/2/src/soc/intel/cannonlake/chip.h
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/#/c/32389/2/src/soc/intel/cannonlake/chip.h@24
PS2, Line 24: #include <smbios.h>
Please why this is included ?
Actually I don't think that's needed any more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47a697131b7aeeb64e0c4b4c0556842f1cb1b02e
Gerrit-Change-Number: 32389
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 01 May 2019 22:33:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment