Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36941 )
Change subject: arch/x86: SMBIOS: Improve core count reporting
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36941/2/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/36941/2/src/arch/x86/smbios.c@677
PS2, Line 677: t->core_count = (res.ebx >> 16) & 0xff;
we can't. […]
I was talking about the runtime extended devicetree where after MP init you will have the real number of CPU cores currently available. That should reflect your variations. But never mind, I am fine with this approach as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36941
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4ba9e3079f92ffe38f9104ffcfafe62582dd259
Gerrit-Change-Number: 36941
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 Nov 2019 05:19:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Gerrit-MessageType: comment