EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39467 )
Change subject: mb/google/drallion: Enable GEO SAR ......................................................................
mb/google/drallion: Enable GEO SAR
Enable GEO SAR function.
BUG=b:150347463 TEST=NA
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Iace9aa0245840328aa13920512747ca7f60e85dd --- M src/mainboard/google/drallion/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39467/1
diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index aff19c8..431644aa 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -40,6 +40,7 @@ select SAR_ENABLE select USE_SAR select WIFI_SAR_CBFS + select GEO_SAR_ENABLE
config DIMM_MAX int
Hello Mathew King, Ivy Jian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39467
to look at the new patch set (#2).
Change subject: mb/google/drallion: Enable GEO SAR ......................................................................
mb/google/drallion: Enable GEO SAR
Enable GEO SAR function.
BUG=b:150347463 TEST=NA
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Iace9aa0245840328aa13920512747ca7f60e85dd --- M src/mainboard/google/drallion/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39467/2
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39467 )
Change subject: mb/google/drallion: Enable GEO SAR ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Mathew King, Ivy Jian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39467
to look at the new patch set (#3).
Change subject: mb/google/drallion: Enable GEO SAR ......................................................................
mb/google/drallion: Enable GEO SAR
Enable GEO SAR function.
BUG=b:150347463 BRANCH=drallion TEST=NA
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Iace9aa0245840328aa13920512747ca7f60e85dd --- M src/mainboard/google/drallion/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39467/3
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39467 )
Change subject: mb/google/drallion: Enable GEO SAR ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39467 )
Change subject: mb/google/drallion: Enable GEO SAR ......................................................................
mb/google/drallion: Enable GEO SAR
Enable GEO SAR function.
BUG=b:150347463 BRANCH=drallion TEST=NA
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Iace9aa0245840328aa13920512747ca7f60e85dd Reviewed-on: https://review.coreboot.org/c/coreboot/+/39467 Reviewed-by: Mathew King mathewk@chromium.org Reviewed-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/drallion/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Ivy Jian: Looks good to me, approved Mathew King: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index aff19c8..c61a5b3 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -37,6 +37,7 @@ bool "Enable SAR options for Chrome OS build" depends on CHROMEOS select DSAR_ENABLE + select GEO_SAR_ENABLE select SAR_ENABLE select USE_SAR select WIFI_SAR_CBFS
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39467 )
Change subject: mb/google/drallion: Enable GEO SAR ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1346 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1345 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1344
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
EricR Lai (Code Review)
-
Ivy Jian (Code Review)
-
Martin Roth (Code Review)
-
Mathew King (Code Review)