Change in coreboot[master]: nb/amd/agesa/family14/northbridge.c: Report missing resources
Attention is currently required from: Nico Huber, Angel Pons, Kyösti Mälkki, Felix Held. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52935 )
Change subject: nb/amd/agesa/family14/northbridge.c: Report missing resources ......................................................................
Patch Set 2:
(4 comments)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/52935/comment/01df3454_4511ebf7 PS2, Line 275: * 0xc0000 - 0xcffff: VGA OPROM
same comment about the d segment here
* 0xd0000 - 0xfffff: SeaBIOS, if used
If I am correct. D segment is used for oproms anyway.
https://review.coreboot.org/c/coreboot/+/52935/comment/cd75ea36_32a6e44e PS2, Line 289: resource_t
unsigned long
why not resource_t?
https://review.coreboot.org/c/coreboot/+/52935/comment/3d860fa9_08d1f303 PS2, Line 382: // 4 1T
What does this comment mean?
No idea, it was just there before. May remove actually
https://review.coreboot.org/c/coreboot/+/52935/comment/ded33f95_638f5420 PS2, Line 382: resource_t
unsigned long
Why? What is the policy behind using resource_t anyway?
-
Michał Żygowski (Code Review)