Change in coreboot[master]: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 8KB

[Anil Kumar K (Code Review)]

Anil Kumar K has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45183 )

Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 8KB
......................................................................

soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 8KB

This patch increases PRERAM_CBMEM_CONSOLE_SIZE from 5KB to 8KB to fix
cbmem buffer overflow issue.

Bug=None
Branch=None
Test=Boot TGLRVP and check cbmem -c | grep 'CBFS: Locating' lists all stages

Signed-off-by: Anil Kumar 
Change-Id: I2393cc83008211be8e6a2ca7a1e41a7e9d92caf0
---
M src/soc/intel/tigerlake/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/45183/1

diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig
index cdec3ef..46bbb74 100644
--- a/src/soc/intel/tigerlake/Kconfig
+++ b/src/soc/intel/tigerlake/Kconfig
@@ -214,5 +214,5 @@

config PRERAM_CBMEM_CONSOLE_SIZE
    hex
-	default 0x1400
+	default 0x2000
 endif

[Anil Kumar K (Code Review)]

Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45183 )

Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 8KB
......................................................................

Patch Set 1: Code-Review+1

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45183 )

Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 8KB
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45183 )

Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 8KB
......................................................................

soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 8KB

This patch increases PRERAM_CBMEM_CONSOLE_SIZE from 5KB to 8KB to fix
cbmem buffer overflow issue.

Bug=None
Branch=None
Test=Boot TGLRVP and check cbmem -c | grep 'CBFS: Locating' lists all stages

Signed-off-by: Anil Kumar 
Change-Id: I2393cc83008211be8e6a2ca7a1e41a7e9d92caf0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45183
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/tigerlake/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved
  Anil Kumar K: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig
index 826f8af..d92d496 100644
--- a/src/soc/intel/tigerlake/Kconfig
+++ b/src/soc/intel/tigerlake/Kconfig
@@ -214,5 +214,5 @@

config PRERAM_CBMEM_CONSOLE_SIZE
    hex
-	default 0x1400
+	default 0x2000
 endif

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45183 )

Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 8KB
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19049
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19048
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19047
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19046
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19045
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19053
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19052
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19051
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19050

Please note: This test is under development and might not be accurate at all!