Attention is currently required from: Mario Scheithauer, Paul Menzel, Werner Zeh.
Johannes Hahn has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/86424?usp=email )
Change subject: src/mainboard/siemens/fa_ehl: Configure LPDDR4 initialization
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c:
https://review.coreboot.org/c/coreboot/+/86424/comment/2e54aba3_ff4e01c7?usp... :
PS5, Line 4: #include <gpio.h>
Acknowledged
Should the whole patch be abandoned so I can dissolve remnant dependencies of it before commiting it anew ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86424?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If84373dfbc1ecbf916489af6e964f8a7541f5e7b
Gerrit-Change-Number: 86424
Gerrit-PatchSet: 6
Gerrit-Owner: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 18 Feb 2025 12:47:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Johannes Hahn
johannes-hahn@siemens.com