Attention is currently required from: Elyes Haouas, Eric Lai, Nick Vaccaro, Subrata Banik, Tarun Tuli.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76873?usp=email )
Change subject: mb/google/brya: Add DRIVERS_GFX_GENERIC to BRYA by default ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/76873/comment/635ee4f0_89a5d90a : PS2, Line 51: config BOARD_GOOGLE_FELWINTER : bool "-> Felwinter" : select BOARD_GOOGLE_BASEBOARD_BRYA : select CHROMEOS_WIFI_SAR if CHROMEOS : select DRIVERS_GENERIC_GPIO_KEYS : select DRIVERS_GENESYSLOGIC_GL9755 : : config BOARD_GOOGLE_GIMBLE : bool "-> Gimble" : select BOARD_GOOGLE_BASEBOARD_BRYA : select GOOGLE_DSM_CALIB if VPD : select GOOGLE_DSM_PARAM_FILE_NAME if VPD : select DRIVERS_GENESYSLOGIC_GL9750 : select DRIVERS_I2C_MAX98390 : : config BOARD_GOOGLE_GIMBLE4ES : bool "-> Gimble4ES" : select BOARD_GOOGLE_BASEBOARD_BRYA : select GOOGLE_DSM_CALIB if VPD : select GOOGLE_DSM_PARAM_FILE_NAME if VPD : select DEFAULT_ADL_NEM : select DRIVERS_GENESYSLOGIC_GL9750 : select DRIVERS_I2C_MAX98390 : : config BOARD_GOOGLE_KANO : bool "-> Kano" : select BOARD_GOOGLE_BASEBOARD_BRYA
you are also selecting DRIVERS_GFX_GENERIC for those (and more), isn't it?
Yes, I have patch series to add gfx devices to other brya models, like felwinter, gimble, kano, and more.