[M] Change in coreboot[main]: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory - coreboot-gerrit

6 Jan 2025


      Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84734?usp=email )
Change subject: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84734/comment/31ce4313_0379ba6c?usp... :
PS6, Line 12: Also, use local variables to cache reads of the same variable.
nit: maybe add 'within a given ACPI method' to the end since to add context
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84734?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0bbb538017cc004bff1989a8017ccfcd1ba9ab5c
Gerrit-Change-Number: 84734
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Comment-Date: Mon, 06 Jan 2025 21:04:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes