Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: 4mb/google/zork: Modify I2C3 CLK for Woomax ......................................................................
4mb/google/zork: Modify I2C3 CLK for Woomax
Modify I2C3 setting: .rise_time_ns = 125 to 110 .fall_time_ns = 37 to 34
BUG=b: BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0f0b791c3e701ebf6b336a8cb259eeb74c46af5a --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/45644/1
diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index de39891..54dd8e6 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -36,8 +36,8 @@ # Enable I2C3 for H1 400kHz register "i2c[3]" = "{ .speed = I2C_SPEED_FAST, - .rise_time_ns = 125, /* 0 to 1.26v (1.8 * .7) */ - .fall_time_ns = 37, /* 1.26v to 0 */ + .rise_time_ns = 110, /* 0 to 1.26v (1.8 * .7) */ + .fall_time_ns = 34, /* 1.26v to 0 */ .early_init = true, }"
Kane Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: 4mb/google/zork: Modify I2C3 CLK for Woomax ......................................................................
4mb/google/zork: Modify I2C3 CLK for Woomax
Modify I2C3 setting: .rise_time_ns = 125 to 110 .fall_time_ns = 37 to 34
BUG=b:169207742 BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0f0b791c3e701ebf6b336a8cb259eeb74c46af5a --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/45644/2
Kane Chen has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax ......................................................................
mb/google/zork: Modify I2C3 CLK for Woomax
Modify I2C3 setting: .rise_time_ns = 125 to 110 .fall_time_ns = 37 to 34
BUG=b:169207742 BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0f0b791c3e701ebf6b336a8cb259eeb74c46af5a --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/45644/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45644
to look at the new patch set (#4).
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification
Original setting: .rise_time_ns = 125 .fall_time_ns = 37
Change to: .rise_time_ns = 110 .fall_time_ns = 34
BUG=b:169207742 BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0f0b791c3e701ebf6b336a8cb259eeb74c46af5a --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/45644/4
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45644/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45644/4//COMMIT_MSG@15 PS4, Line 15: .fall_time_ns = 34 Might be worth noting what the frequency is now vs before or what these changes accomplished.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45644/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45644/4//COMMIT_MSG@15 PS4, Line 15: .fall_time_ns = 34
Might be worth noting what the frequency is now vs before or what these changes accomplished.
Dear Aaron, Original setting measured value about 407~408kHz, the measured value after modification is lower than 400kHz(about 397kHz), thanks.
Hello build bot (Jenkins), Furquan Shaikh, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45644
to look at the new patch set (#5).
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification
Modify I2C3 setting to follow specification(lower than 400kHz). Original setting: .rise_time_ns = 125 .fall_time_ns = 37
Change to: .rise_time_ns = 110 .fall_time_ns = 34
BUG=b:169207742 BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0f0b791c3e701ebf6b336a8cb259eeb74c46af5a --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/45644/5
Hello build bot (Jenkins), Furquan Shaikh, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45644
to look at the new patch set (#6).
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification
Modify I2C3 setting to follow I2C specification(lower than 400kHz). Original setting: .rise_time_ns = 125 .fall_time_ns = 37
Change to: .rise_time_ns = 110 .fall_time_ns = 34
BUG=b:169207742 BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0f0b791c3e701ebf6b336a8cb259eeb74c46af5a --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/45644/6
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
Patch Set 6:
Make sure to resolve the comments.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
Patch Set 6:
(1 comment)
Patch Set 6:
Make sure to resolve the comments.
https://review.coreboot.org/c/coreboot/+/45644/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45644/4//COMMIT_MSG@15 PS4, Line 15: .fall_time_ns = 34
Dear Aaron, […]
Done
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
Patch Set 6: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
Patch Set 6: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification
Modify I2C3 setting to follow I2C specification(lower than 400kHz). Original setting: .rise_time_ns = 125 .fall_time_ns = 37
Change to: .rise_time_ns = 110 .fall_time_ns = 34
BUG=b:169207742 BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0f0b791c3e701ebf6b336a8cb259eeb74c46af5a Reviewed-on: https://review.coreboot.org/c/coreboot/+/45644 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Angel Pons: Looks good to me, approved Kane Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index d1c5507..8d94a97 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -60,8 +60,8 @@ # Enable I2C3 for H1 400kHz register "i2c[3]" = "{ .speed = I2C_SPEED_FAST, - .rise_time_ns = 125, /* 0 to 1.26v (1.8 * .7) */ - .fall_time_ns = 37, /* 1.26v to 0 */ + .rise_time_ns = 110, /* 0 to 1.26v (1.8 * .7) */ + .fall_time_ns = 34, /* 1.26v to 0 */ .early_init = true, }"
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Kane Chen (Code Review)