Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45685 )
Change subject: soc/intel/tigerlake: Remove extra '_' from GPIO PIN name ......................................................................
soc/intel/tigerlake: Remove extra '_' from GPIO PIN name
Fix typo GPD__SLP_SUSB -> GPD_SLP_SUSB
Change-Id: I2beddb5665dc2f6a28b9c02e240b12da137c1b17 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45685/1
diff --git a/src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h b/src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h index d4c7750..607183a 100644 --- a/src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h +++ b/src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h @@ -240,7 +240,7 @@ #define GPD11 182 #define GPD_INPUT3VSEL 183 #define GPD_SLP_LANB 184 -#define GPD__SLP_SUSB 185 +#define GPD_SLP_SUSB 185 #define GPD_WAKEB 186 #define GPD_DRAM_RESETB 187
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45685 )
Change subject: soc/intel/tigerlake: Remove extra '_' from GPIO PIN name ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45685 )
Change subject: soc/intel/tigerlake: Remove extra '_' from GPIO PIN name ......................................................................
soc/intel/tigerlake: Remove extra '_' from GPIO PIN name
Fix typo GPD__SLP_SUSB -> GPD_SLP_SUSB
Change-Id: I2beddb5665dc2f6a28b9c02e240b12da137c1b17 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45685 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h b/src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h index d4c7750..607183a 100644 --- a/src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h +++ b/src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h @@ -240,7 +240,7 @@ #define GPD11 182 #define GPD_INPUT3VSEL 183 #define GPD_SLP_LANB 184 -#define GPD__SLP_SUSB 185 +#define GPD_SLP_SUSB 185 #define GPD_WAKEB 186 #define GPD_DRAM_RESETB 187
-
HAOUAS Elyes (Code Review) -
Subrata Banik (Code Review)