Change in coreboot[master]: lint/checkpatch.pl: Remove unneeded whitespace - coreboot-gerrit

31 Mar 2020

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39992 )
Change subject: lint/checkpatch.pl: Remove unneeded whitespace
......................................................................
lint/checkpatch.pl: Remove unneeded whitespace
Change-Id: I74a0b8558f2cd39e313cac9fdb48a569ae6e7550
Signed-off-by: Elyes HAOUAS ehaouas@noos.fr
---
M util/lint/checkpatch.pl
1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/39992/1

diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl
index 1affdb7..5d9c0cd 100755
--- a/util/lint/checkpatch.pl
+++ b/util/lint/checkpatch.pl
@@ -4437,7 +4437,7 @@
    				    ($op eq '>' &&
    				     $ca =~ /<\S+@\S+$/))
    				{
-					    	$ok = 1;
+						$ok = 1;
    				}
# for asm volatile statements
@@ -4499,19 +4499,19 @@
## # check for multiple declarations, allowing for a function declaration
 ## # continuation.
-## 		if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
-## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
+##		if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
+##		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
 ##
-## 			# Remove any bracketed sections to ensure we do not
-## 			# falsly report the parameters of functions.
-## 			my $ln = $line;
-## 			while ($ln =~ s/([^()]*)//g) {
-## 			}
-## 			if ($ln =~ /,/) {
-## 				WARN("MULTIPLE_DECLARATION",
+##			# Remove any bracketed sections to ensure we do not
+##			# falsly report the parameters of functions.
+##			my $ln = $line;
+##			while ($ln =~ s/([^()]*)//g) {
+##			}
+##			if ($ln =~ /,/) {
+##				WARN("MULTIPLE_DECLARATION",
 ##				     "declaring multiple variables together should be avoided\n" . $herecurr);
-## 			}
-## 		}
+##			}
+##		}
#need space before brace following if, while, etc
    	if (($line =~ /(.*){/ && $line !~ /($Type){/) ||
@@ -4773,7 +4773,7 @@
    		# conditional.
    		substr($s, 0, length($c), '');
    		$s =~ s/\n.*//g;
-			$s =~ s/$;//g; 	# Remove any comments
+			$s =~ s/$;//g;	# Remove any comments
    		if (length($c) && $s !~ /^\s*{?\s*\*\s*$/ &&
    		    $c !~ /}\s*while\s*/)
    		{
@@ -4812,7 +4812,7 @@
 # if and else should not have general statements after it
    	if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
    		my $s = $1;
-			$s =~ s/$;//g; 	# Remove any comments
+			$s =~ s/$;//g;	# Remove any comments
    		if ($s !~ /^\s*(?:\sif|(?:{|)\s*\?\s*$)/) {
    			ERROR("TRAILING_STATEMENTS",
    			      "trailing statements should be on next line\n" . $herecurr);
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/39992
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74a0b8558f2cd39e313cac9fdb48a569ae6e7550
Gerrit-Change-Number: 39992
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-MessageType: newchange



    